BinNormalisation::undo(ProjData&,...) should not need symmetries_sptr arg
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 160
- Forks
- 113
- Avg merge
- 12d 15h
- Merged PRs (30d)
- 1
Description
signature is currently
BinNormalisation::
undo(ProjData& proj_data,const double start_time, const double end_time,
shared_ptr<DataSymmetriesForViewSegmentNumbers> symmetries_sptr) const
The symmetries_sptr is there for BinNormalisationFromAttenuationImage . It would be far better to get this from the BinNormalisation object itself. This would presumably need a get_data_symmetries_sptr virtual function.
Root-reason is that BinNormalisation works via RelatedViewgrams, but that is again needed for BinNormalisationFromAttenuationImage`.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing BinNormalisation::undo and the uses of BinNormalisationFromAttenuationImage, including how RelatedViewgrams supplies symmetry information. Determine how a get_data_symmetries_sptr virtual function could replace the symmetries_sptr parameter and identify all affected callers. Done means the object provides the required symmetries without that argument and the related code remains consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100