apply_normfactors* might miss 1 line in the projdata
A pull request for this has already been merged.
- #829 by @KrisThielemans — merged
- Dominant language
- C++
- Stars
- 160
- Forks
- 113
- Avg merge
- 12d 15h
- Merged PRs (30d)
- 1
Description
When there's an even number of tangential positions in the projdata, the most negative tangential pos is not filled in by construct_randoms_from_singles as we rely on a half_fan_size and then an odd fan_size. This could create trouble in some cases (for instance, the randoms background would be estimated to be zero). As this tangential position shouldn't influence the FOV (or just its edge), this is probably a corner case.
Need to check if the same problem appears in the normalisation code.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing construct_randoms_from_singles and the apply_normfactors* normalization code for even numbers of tangential positions. Check whether the most negative tangential position is omitted in both paths, then verify that the normalization behavior covers this corner case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100