switch proj-matrix caching off in calculate_attenuation_coefficients
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- C++
- Stars
- 160
- Forks
- 113
- Avg merge
- 12d 15h
- Merged PRs (30d)
- 1
Description
It doesn't make sense to cache the projection matrix for this one-off calculation. This would be easy to do along the same lines as
https://github.com/UCL/STIR/blob/59c3896524cd7669c0a81c5e5eea49368dff4f1e/src/recon_buildblock/PoissonLogLikelihoodWithLinearModelForMeanAndProjData.cxx#L676-L682
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate calculate_attenuation_coefficients and compare its projection-matrix handling with the linked PoissonLogLikelihoodWithLinearModelForMeanAndProjData.cxx lines 676-682. Done means the projection matrix is not cached for this one-off calculation; run the relevant existing tests or checks for attenuation-coefficient calculation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- performance
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100