Use BUILD_LOCAL_INTERFACE:nlohmann_json::nlohmann_json
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 160
- Forks
- 113
- Avg merge
- 12d 15h
- Merged PRs (30d)
- 1
Description
CMake 3.26 will resolve an ugly work-around here
https://github.com/UCL/STIR/blob/4a9391257c76e8b8b1b68c22bc81fa92033bff77/src/IO/CMakeLists.txt#L119-L130
we'd need to guard it with CMake version numbers
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/IO/CMakeLists.txt at lines 119-130 and review the linked CMake issue about BUILD_LOCAL_INTERFACE and CMake 3.26. Update the workaround with the required CMake version guard so nlohmann_json::nlohmann_json is used appropriately; done means the CMake configuration works with the supported versions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100