TuringLang / TuringLang/DynamicPPL.jl
Don't use deepcopy
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Julia
- Stars
- 286
- Forks
- 41
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 34
Description
We use deepcopy a lot, but this is considered bad. We might be okay because I think we are mostly deepcopying arrays, but we should go over the codebase and switch to copy where possible and make sure the remaining cases make sense and are documented.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the codebase for uses of deepcopy and inspect each call to determine whether copy is sufficient. The work is done when applicable uses are switched, remaining uses are justified, and those cases are documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100