TuringLang / TuringLang/DynamicPPL.jl

Remove `NoDist` in favour of `fix`.

Open
#760 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

breaking-change modelling-syntax
Dominant language
Julia
Stars
286
Forks
41
Avg merge
1d 11h
Merged PRs (30d)
34

Description

https://github.com/TuringLang/DynamicPPL.jl/blob/d0cfaaf9c27a15ada0010b389b32a5d16acd4666/src/distribution_wrappers.jl#L32-L35

can be removed without regression now that we have fix(model, (var=...)). The semantics of NoDist and fix are identical, while fix is more compositional and avoids hardcoding fixed variable information in model specification.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/distribution_wrappers.jl at the linked NoDist definition and search the repository for its remaining references. Replace the old usage with the existing fix(model, (var=...)) approach, remove NoDist, and run the project’s tests to confirm there is no regression.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
machine-learning
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.