TuringLang / TuringLang/AbstractMCMC.jl
Improve callbacks
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 108
- Forks
- 20
- PR merge metrics
- No merged PRs in 30d
Description
Callbacks can be incredibly useful, e.g. TuringCallbacks.jl with TensorBoardLogging.jl integration.
However, there are many "standard" callbacks that we arguably should provide some default implementation (i.e. that have "zero" dependencies) of:
-
StateHistoryCallback: simply extracts the states from asamplecall. This is useful if one wants to inspect sampler parameters, etc. that aren't necessarily part of the transitions. Ref: #84 - :
MultipleCallback: a wrapper around multiple callbacks to make it easier to pass many of them. Ref: #80 - ???
The question is then: should these go in AbstractMCMC.jl itself, or should we put them in a separate package?
And if we're putting them in a separate package (which I also think is the best approach here), then do we put them in a package called AbstractMCMCCallbacks.jl or in the existing TuringCallbacks.jl?
Thoughts? @devmotion @yebai @sunxd3 @mhauru @penelopeysm
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the proposed StateHistoryCallback and MultipleCallback in this issue, along with references #84 and #80. Resolve whether standard callbacks belong in AbstractMCMC.jl or a separate package, and whether that package should be AbstractMCMCCallbacks.jl or TuringCallbacks.jl; done requires an agreed scope and package decision.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- backend-api-design
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100