`kinks` possible false positives on Yosemite polygon
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 10.5k
- Forks
- 1k
- Avg merge
- 1h 11m
- Merged PRs (30d)
- 4
Description
This polygon geometry for Yosemite has a hole in it at (-119.84323,37.83471) where it overlaps with Stanislaus National Forest. The polygon is otherwise valid, but the inner ring causes kinks to return four self-intersections due to the corner at (-119.84566, 37.83285). But the inner ring is a self-tangency, not a self-intersection, so it seems like there should be no kinks.
Whether self-tangency makes a polygon "invalid" is apparently a point of contention; relevant spec links:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the kinks implementation and reproduce the report with yosemite-national-park.json, focusing on the inner ring near the supplied coordinates. Read the linked OGC and Mapbox validity guidance before deciding how self-tangency should be classified. Done means the Yosemite geometry no longer produces false self-intersections, with behavior consistent with the chosen specification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100