Turfjs / Turfjs/turf

[@turf/concave] Returns a convex hull instead of a concave one

Open
#1,436 5 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

@turf/concave
Dominant language
TypeScript
Stars
10.5k
Forks
1k
Avg merge
1h 11m
Merged PRs (30d)
4

Description

Not sure if it always happen, but here is an example of coordinates for which the hull is not concave. Just to be sure that we talk about the same concave hull, here is what I expect:

My version is @turf/concave@6.0.5 but it seems like the same bug appears on older versions too.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the coordinates from the linked gist with @turf/concave@6.0.5, then inspect the @turf/concave implementation and its existing tests. Done means the reported input produces a concave hull matching the expected shape rather than a convex hull, with a regression test covering the case.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.