TryGhost / TryGhost/Source

gh-navigation-menu hidden with JS disabled

Open
#49 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
CSS
Stars
129
Forks
258
Avg merge
2h 57m
Merged PRs (30d)
36

Description

There is this CSS:

@media (min-width: 768px) {
    .gh-navigation:not(.is-dropdown-loaded) .gh-navigation-menu .nav>li {
        opacity: 0;
    }
}

which hides/disables the nav menu when JS is disabled. This effects all websites, even those with no dropdown usage.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the theme styles for the .gh-navigation:not(.is-dropdown-loaded) .gh-navigation-menu .nav li rule shown in the issue. Check the navigation with JavaScript disabled and enabled, then confirm the menu remains visible without JavaScript while dropdown navigation still works when JavaScript is available.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.