TryGhost / TryGhost/NQL

Support for empty literals, strings and groups

Open
#19 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
7
Forks
7
Avg merge
9h 4m
Merged PRs (30d)
22

Description

Originally reported at https://github.com/TryGhost/GQL/issues/36


See: https://github.com/TryGhost/Ghost/issues/9258 & https://github.com/TryGhost/Casper/issues/382

I've seen this pop up a few times. If you use dynamic queries, there's no guarantee that you will get anything output, and then NQL will throw a parse error.

Short term the solution is to put guards around dynamic queries, but I think we can do better in NQL Lang, by handling the concept of an empty clause, and removing the whole clause if empty.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by reproducing the parse error when a dynamic query produces no output, then trace how NQL Lang parses empty literals, strings, and groups; done means empty clauses no longer cause parse errors and their removal behavior is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.