TryGhost / TryGhost/NQL

Consider relaxing literals

Open
#17 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
7
Forks
7
Avg merge
9h 4m
Merged PRs (30d)
22

Description

Currently a literal is defined as:

Any character string which follows these rules:
- Cannot start with - or : but may contain them
- Cannot contain any of these symbols: '"+,()><=[] unless they are escaped
- Cannot contain whitespace
  • reconsider not allowing : at the start
  • reconsider if non-quote symbols can be allowed inside, but not at the start/end without escaping
  • reconsider whitespace

When reconsidering we must:

  • look for valid use cases
  • write lots of tests in both the lexer and parser

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the lexer and parser, then review valid use cases for leading colons, embedded non-quote symbols, and whitespace in literals. Done means deciding the accepted literal rules and adding comprehensive tests in both the lexer and parser.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.