TritonDataCenter / TritonDataCenter/sdc-cloudapi
InternalError exceptions when handling user ids in roles
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 8
- Forks
- 22
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 1
Description
sdc-cloudapi currently uses node-mahi version 2.3.0. This version has a double-callback bug in its getUserById() implementation., which is exposed when using roles that have members identified by id instead of login. mahi client v2.3.1 fixes this.
Update cloudapi to use mahi client 2.3.3, and add tests to cover using "id" instead of "login" when creating or using roles.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate cloudapi's dependency declaration and the tests covering roles, then inspect how node-mahi's getUserById() is used for role members. Update the mahi client to 2.3.3 and add coverage for creating and using roles with members identified by id instead of login; done means those tests pass without InternalError exceptions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, nodejs
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100