TritonDataCenter / TritonDataCenter/pkgsrc-joyent

quickbackup-percona fails to detect xbstream format correctly

Open
#18 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Makefile
Stars
32
Forks
28
PR merge metrics
No merged PRs in 30d

Description

When attempting to restore an xbstream backup:

$ sudo quickbackup-percona restore /home/admin/2015-05-08_12-00-00-backup.xbs - Restore from /home/admin/2015-05-08_12-00-00-backup.xbs

ERROR - /home/admin/2015-05-08_12-00-00-backup.xbs appears to not be xbstream format.
Check that your quickbackup/stream setting is set to the type of file
you are trying to restore.

This definitely is an xbstream backup. The culprit is this line (line 321 in the version that came with my image):

[ `file ${RESTOREFILE} | awk '{ print $2 }'` != "data" ] && logerror "\nERROR - ${RESTOREFILE} appears to not be xbstream format.

When I comment it out the restore runs without issue.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the quickbackup-percona restore path and the format check identified as line 321, especially the file ${RESTOREFILE} | awk '{ print $2 }' command. Reproduce the restore with the provided .xbs example and verify that a valid xbstream backup is detected without disabling the check.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
databases
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.