Tripletex / Tripletex/tripletex-api2

Validation error on uploading customer`s organizationNumber with string longer/shorter than 9

Open
#51 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
49
Forks
47
Avg merge
1h 1m
Merged PRs (30d)
1

Description

PUT /customer

image

body:
{
"organizationNumber": "444444-4444"
}

response:
{
"status": 422,
"code": 18000,
"message": "Validation failed.",
"link": "https://www.tripletex.no/tripletex-api-2-0/",
"developerMessage": "VALIDATION_ERROR",
"validationMessages": [
{
"field": "organizationNumber",
"message": "The organization number must consist of 9 numbers and cannot have any spaces.",
"path": null,
"rootId": null
}
],
"requestId": "07c35378-a8e9-43f7-8852-c33c5e0aeabe"
}

Tripletex docs clearly says that limit for this field is 100 chars

image

Also, POST /customer allows strings shorter/longer then 9, at least it allows them now

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the PUT /customer validation shown in the issue and compare it with POST /customer and issue #13. Check the documented 100-character limit against the organizationNumber validation behavior; done means the endpoint behavior and documentation agree on the accepted value format.

Written by the indexing model from the issue text.

Assessment

Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.