Tripletex / Tripletex/tripletex-api2

Make warehouseId optional when creating orderLines - choose default warehouse for that product when not set

Open
#50 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
49
Forks
47
Avg merge
1h 1m
Merged PRs (30d)
1

Description

Our integration has a config "What warehouse should orderslines use". In most cases our clients only have one warehouse, so this works fine. But sometimes they forget to assign aome of their products to their "default" warehouse, causing issues when we try to create order(lines). Invalid warehouse ID for product.

A feature request is therefore:

  1. Assign automatically the "main warehouse" to all new products.
  2. Make it possible to have "default" warehouse for each product.
  3. Make it possible to NOT set warehouseId when creating orders via API, and let Tripletex choose the default warehouse for that product/orderline

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the API flow for creating products and order lines, then review how warehouseId and product warehouse assignments are currently handled. Clarify the intended relationship between a main warehouse, a per-product default, and an omitted warehouseId. Done should cover the three requested behaviors and avoid the reported invalid warehouse ID error.

Written by the indexing model from the issue text.

Assessment

Domain
api, backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.