TrinityCore / TrinityCore/WowPacketParser
SMSG_GARRISON_COMPLETE_MISSION_RESULT not fully readed
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 522
- Forks
- 387
- Avg merge
- 3d 6h
- Merged PRs (30d)
- 4
Description
[5] FollowerDBID: 0
System.IO.EndOfStreamException
Unable to read beyond the end of the stream.
at System.IO.BinaryReader.InternalRead(Int32 numBytes)
at System.IO.BinaryReader.ReadUInt32()
at WowPacketParser.Misc.Packet.ReadUInt32(String name, Object[] indexes) in C:\Users\thord\Desktop\shadowlandsparser\WowPacketParser\Misc\PacketReads.cs:line 382
at WowPacketParserModule.V7_0_3_22248.Parsers.GarrisonHandler.HandleGarrisonFinishMission(Packet packet) in C:\Users\thord\Desktop\shadowlandsparser\WowPacketParserModule.V7_0_3_22248\Parsers\GarrisonHandler.cs:line 331
at WowPacketParser.Parsing.Handler.Parse(Packet packet, Boolean isMultiple) in C:\Users\thord\Desktop\shadowlandsparser\WowPacketParser\Parsing\Handler.cs:line 149
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in WowPacketParserModule.V7_0_3_22248/Parsers/GarrisonHandler.cs at HandleGarrisonFinishMission, especially the read reported at line 331. Reproduce the SMSG_GARRISON_COMPLETE_MISSION_RESULT packet and trace the preceding Packet.ReadUInt32 calls against the available packet data. Done means the packet is parsed without EndOfStreamException.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- reverse-engineering, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100