TrinityCore / TrinityCore/WowPacketParser

Create ObjectNames sql output is broken

Open
#222 2 comments 0 reactions 1 assignee View on GitHub

@Vincent-Michael is already working on this.

Since Dec 30, 2015.

bug
Dominant language
C#
Stars
522
Forks
387
Avg merge
3d 6h
Merged PRs (30d)
4

Description

Support current:
https://github.com/TrinityCore/WowPacketParser/blob/888f64830cbf782dd4dd4ac61e2ed01762d46ca3/WowPacketParser/Store/Objects/ObjectName.cs#L9-L10

https://github.com/TrinityCore/WowPacketParser/blob/888f64830cbf782dd4dd4ac61e2ed01762d46ca3/WowPacketParser/Enums/ObjectType.cs#L3-L17

Should but:
https://github.com/TrinityCore/WowPacketParser/blob/888f64830cbf782dd4dd4ac61e2ed01762d46ca3/WowPacketParser/Enums/StoreNameType.cs#L5-L29

https://github.com/TrinityCore/WowPacketParser/blob/888f64830cbf782dd4dd4ac61e2ed01762d46ca3/WowPacketParser/SQL/SQLDatabase.cs#L53-L61

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/29479773-create-objectnames-sql-output-is-broken?utm_campaign=plugin&utm_content=tracker%2F457228&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F457228&utm_medium=issues&utm_source=github).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.