TrinityCore / TrinityCore/TrinityCoreCustomChanges
3.3.5-passive_anticheat log suggestion
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 83
- Forks
- 58
- PR merge metrics
- No merged PRs in 30d
Description
Description:
Woud be great when Anticheat.WriteLog = 0 it will not create the empty document log at all.
This is somehow annoying while testing because it does fill logs folder on every server start-up.
Current behaviour:
Atm when Anticheat.WriteLog = 0 / is disabled in config it will still create the empty document with anticheat_y-m-d-h-m-s.txt
Expected behaviour:
Maybe when Anticheat.WriteLog = 0, the log file not be created at all or at least overwrited at next start-up
Steps to reproduce the problem:
- Set Anticheat.WriteLog = 0 in worldserver config then start the server
- notice the empty log is still created
Branch(es):
3.3.5
TC rev. hash/commit:
d434182e30dd
TDB version: TDB335.2404
Operating system: Windows 11 x64
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue on the 3.3.5 branch using the worldserver configuration with Anticheat.WriteLog = 0, then trace the startup path that creates files in the logs folder. Compare startup behavior with logging enabled and disabled, and confirm that disabling the setting no longer creates an empty anticheat_y-m-d-h-m-s.txt file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100