TrinityCore / TrinityCore/TrinityCore

Spells/Priest: Implement Prayer Circle

Open
#29,039 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Branch-master Comp-Database Feedback-PatchFix
Dominant language
C++
Stars
10.8k
Forks
6.4k
Avg merge
3d 16m
Merged PRs (30d)
6

Description

Description
  • Implement Prayer Circle talent.
SQL fix
DELETE FROM `spell_proc` WHERE `SpellId` IN (321377);
INSERT INTO `spell_proc` (`SpellId`,`SchoolMask`,`SpellFamilyName`,`SpellFamilyMask0`,`SpellFamilyMask1`,`SpellFamilyMask2`,`SpellFamilyMask3`,`ProcFlags`,`ProcFlags2`,`SpellTypeMask`,`SpellPhaseMask`,`HitMask`,`AttributesMask`,`DisableEffectsMask`,`ProcsPerMinute`,`Chance`,`Cooldown`,`Charges`) VALUES
(321377,0x00,6,0x00000000,0x00000000,0x00400000,0x00000000,0x0,0x0,0x0,0x1,0x0,0x0,0x0,0,0,0,0); -- Prayer Circle
Branch

master

TC rev. hash/commit

TC rev. hash/commit: https://github.com/TrinityCore/TrinityCore/commit/3ca9e1253a127daea2ff1b8b0eb5236aa04f772e

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Prayer Circle talent and spell ID 321377 in the TrinityCore sources, then inspect the spell_proc row specified in the issue. Done means the talent is implemented and the provided spell_proc SQL fix is applied and verified on the master branch.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, sql
Domain
databases, game-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.