TrinityCore / TrinityCore/TrinityCore

Core/GameObject: GAMEOBJECT_TYPE_GOOBER does not send custom anim (if has any)

Open
#27,573 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Branch-3.3.5a Comp-Core Sub-GameObject
Dominant language
C++
Stars
10.8k
Forks
6.4k
Avg merge
3d 16m
Merged PRs (30d)
6

Description

Description
            if (info->goober.customAnim)
                SendCustomAnim(GetGoAnimProgress());

That customAnim actually refers to GameObjectActions (1, 2, 3, 4), usually just 1 (AnimateCustom0 = 1)
It does not work currently

All 4 anims in master

 entry  displayid  name              data4  
------  ---------  ---------------  --------
230963       1027  Pillar of Flame         1
230962       1027  Pillar of Wind          2
230964       1027  Pillar of Water         3
230961       1027  Pillar of Earth         4

I forced some of them to play anim in scripts, sometimes they have anim, sometimes they don't. It's fine, model simply has no custom anim, there's nothing we can or should do

Weirdly enough customAnim of GAMEOBJECT_TYPE_QUESTGIVER works but seems to be handled in client

Expected behaviour

Instead of calling SendCustomAnim(GetGoAnimProgress()), ActivateObject should be called
There may be typos in gameobject_template, maybe a check is needed to activate object only if customAnim is 1 - 4

Steps to reproduce the problem

.gob add temp 3189
.q a 786 (just in case, not needed atm)
use it
no anim

Branch

3.3.5

TC rev. hash/commit

7709837

Operating system

Win 8.1

Custom changes

none

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the GAMEOBJECT_TYPE_GOOBER handling and compare its custom animation path with the GAMEOBJECT_TYPE_QUESTGIVER behavior. Reproduce with .gob add temp 3189, then verify that the relevant Goober game objects activate their custom animation when applicable without affecting objects whose models have no custom animation.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.