TrinityCore / TrinityCore/TrinityCore

Core/Creature: `creature`.`faction`

Open
#25,803 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Comp-Core Priority-FutureFeatureRequest Sub-Creature
Dominant language
C++
Stars
10.8k
Forks
6.4k
Avg merge
3d 16m
Merged PRs (30d)
6

Description

We need another column to override faction in creature table

[25] UpdateType: CreateObject1
[25] GUID: Full: 0xF130003BF7002307 Type: Creature Entry: 15351 Low: 8967
[25] Object Type: 3 (Unit)
[25] Update Flags: 96 (Living, StationaryObject)
[25] Movement Flags: 0 (None)
[25] Extra Movement Flags: 0 (None)
[25] Time: 2167282161
[25] Position: X: 5647.5024 Y: 805.0453 Z: 653.78094
[25] Orientation: 5.585053443908691406
[25] Fall Time: 0
[25] Walk Speed: 2.5
[25] Run Speed: 8
[25] RunBack Speed: 4.5
[25] Swim Speed: 4.722222328186035156
[25] SwimBack Speed: 2.5
[25] Turn Speed: 7
[25] Fly Speed: 4.5
[25] FlyBack Speed: 3.141592741012573242
[25] Pitch Speed: 3.141592741012573242
[25] OBJECT_FIELD_GUID: Full: 0xF130003BF7002307 Type: Creature Entry: 15351 Low: 8967
[25] OBJECT_FIELD_TYPE: 9
[25] OBJECT_FIELD_ENTRY: 15351
[25] OBJECT_FIELD_SCALE_X: 1
[25] UNIT_FIELD_BYTES_0: 0/1/0/1
[25] UNIT_FIELD_HEALTH: 126000
[25] UNIT_FIELD_POWER3: 100/1.4E-43
[25] UNIT_FIELD_POWER4: 100/1.4E-43
[25] UNIT_FIELD_POWER5: 1000000/1.401298E-39
[25] UNIT_FIELD_MAXHEALTH: 126000/1.76564E-40
[25] UNIT_FIELD_MAXPOWER3: 100/1.4E-43
[25] UNIT_FIELD_MAXPOWER4: 100/1.4E-43
[25] UNIT_FIELD_MAXPOWER5: 1000000/1.401298E-39
[25] UNIT_FIELD_LEVEL: 80/1.12E-43
[25] UNIT_FIELD_FACTIONTEMPLATE: 534/7.48E-43 (534)
[25] UNIT_FIELD_FLAGS: 320
[25] UNIT_FIELD_FLAGS_2: 2048
[25] UNIT_FIELD_BASEATTACKTIME: 2000/2.803E-42
[25] UNIT_FIELD_BASEATTACKTIME + 1: 2000/2.803E-42
[25] UNIT_FIELD_BOUNDINGRADIUS: 0.3817
[25] UNIT_FIELD_COMBATREACH: 1.6500001
[25] UNIT_FIELD_DISPLAYID: 27154/3.8051E-41
[25] UNIT_FIELD_NATIVEDISPLAYID: 27154/3.8051E-41
[25] UNIT_MOD_CAST_SPEED: 1065353216/1
[25] UNIT_NPC_FLAGS: 3/4E-45
[25] UNIT_FIELD_BYTES_2: 1/0/0/0
[25] UNIT_FIELD_HOVERHEIGHT: 1

[5] UpdateType: CreateObject1
[5] GUID: Full: 0xF130003BF7001FD8 Type: Creature Entry: 15351 Low: 8152
[5] Object Type: 3 (Unit)
[5] Update Flags: 96 (Living, StationaryObject)
[5] Movement Flags: 0 (None)
[5] Extra Movement Flags: 0 (None)
[5] Time: 2034268640
[5] Position: X: -5049.987 Y: -1270.2637 Z: 510.40768
[5] Orientation: 0.03490658476948738
[5] Fall Time: 0
[5] Walk Speed: 2.5
[5] Run Speed: 8
[5] RunBack Speed: 4.5
[5] Swim Speed: 4.722222328186035156
[5] SwimBack Speed: 2.5
[5] Turn Speed: 7
[5] Fly Speed: 4.5
[5] FlyBack Speed: 3.141592741012573242
[5] Pitch Speed: 3.141592741012573242
[5] OBJECT_FIELD_GUID: Full: 0xF130003BF7001FD8 Type: Creature Entry: 15351 Low: 8152
[5] OBJECT_FIELD_TYPE: 9
[5] OBJECT_FIELD_ENTRY: 15351
[5] OBJECT_FIELD_SCALE_X: 1
[5] UNIT_FIELD_BYTES_0: 0/1/0/1
[5] UNIT_FIELD_HEALTH: 126000
[5] UNIT_FIELD_POWER3: 100/1.4E-43
[5] UNIT_FIELD_POWER4: 100/1.4E-43
[5] UNIT_FIELD_POWER5: 1000000/1.401298E-39
[5] UNIT_FIELD_MAXHEALTH: 126000/1.76564E-40
[5] UNIT_FIELD_MAXPOWER3: 100/1.4E-43
[5] UNIT_FIELD_MAXPOWER4: 100/1.4E-43
[5] UNIT_FIELD_MAXPOWER5: 1000000/1.401298E-39
[5] UNIT_FIELD_LEVEL: 80/1.12E-43
[5] UNIT_FIELD_FACTIONTEMPLATE: 55/7.7E-44 (55)
[5] UNIT_FIELD_FLAGS: 64
[5] UNIT_FIELD_FLAGS_2: 2048
[5] UNIT_FIELD_BASEATTACKTIME: 2000/2.803E-42
[5] UNIT_FIELD_UNK63: 2000/2.803E-42
[5] UNIT_FIELD_BOUNDINGRADIUS: 0.3817
[5] UNIT_FIELD_COMBATREACH: 1.6500001
[5] UNIT_FIELD_DISPLAYID: 27154/3.8051E-41
[5] UNIT_FIELD_NATIVEDISPLAYID: 27154/3.8051E-41
[5] UNIT_MOD_CAST_SPEED: 1065353216/1
[5] UNIT_NPC_FLAGS: 131/1.84E-43
[5] UNIT_FIELD_BYTES_2: 1/1/0/0
[5] UNIT_FIELD_HOVERHEIGHT: 1

Branch(es): both
TC rev. hash/commit: 94c03b2107ad

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the creature table schema and the code path that supplies a creature's faction, using the two provided object traces as the expected differing values. Done means both branches support the additional creature.faction column and the resulting faction can be overridden as requested.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, sql
Domain
backend, database
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.