TrinityCore / TrinityCore/TrinityCore

[3.3.5] Guardians not saving autocast state

Open
#25,148 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Branch-3.3.5a Comp-Core Sub-PetMinion
Dominant language
C++
Stars
10.8k
Forks
6.4k
Avg merge
3d 16m
Merged PRs (30d)
6

Description

Description: Guardians is not saving autocast state or pet state (aggressive, defensive, passive).

Expected behaviour: Guardians like Feral Spirit (Shaman) should save autocast state of spells, and pet state.

PS: It work fine for pets, just not work to guardians

Steps to reproduce the problem:

  1. cast guardian spirit (spellid = 51533)
  2. Remove or add autocast of any spell or change pet state
  3. Dismiss (or wait they vanish) and cast other. You'll see that any change was reseted

Branch(es): 3.3.5

TC rev. hash/commit: 480dee3125929181b7004810516ea673c61f5811

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start on the 3.3.5 branch by reproducing the issue with guardian spell 51533 and the listed autocast and pet-state changes. Trace guardian dismissal and resummoning to find where those states are lost; done means guardian autocast and aggressive, defensive, or passive state persist after the guardian is replaced.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.