TrinityCore / TrinityCore/TrinityCore

Core/Scripts: SM Armory Herod boss

Open
#24,957 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Branch-3.3.5a Comp-C++Script Sub-Instances
Dominant language
C++
Stars
10.8k
Forks
6.4k
Avg merge
3d 16m
Merged PRs (30d)
6

Description

Description:

https://github.com/TrinityCore/TrinityCore/blob/5ac25bb7844ce0816796236bdafce2105e84d8c4/src/server/scripts/EasternKingdoms/ScarletMonastery/boss_herod.cpp#L43

  • During the fight, Herod doesn't summon 4x Myrmidon guards in the hall, that prevent low-level players from running away.
  • Trainee spawn right at the door

Expected behavior:

  • Myrmidons spawn in the hall and despawn after the boss is killed or loses aggro.

1

  • Trainee spawn in the hall and not just in one point

2

Screenshots were taken from 1.13 WoW Classic. I expect the same behavior should be the same till the expansion when Scarlet Monastary had been reworked.

Steps to reproduce the problem:

  1. Start a fight with Herod.
  2. Kill the boss.

Branch(es):

3.3.5

TC rev. hash/commit:

bf62901053d2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/server/scripts/EasternKingdoms/ScarletMonastery/boss_herod.cpp at the linked Herod script and compare its encounter behavior with the expected 1.13 WoW Classic behavior described in the issue. Reproduce the fight on the 3.3.5 branch, then verify that four Myrmidons appear in the hall, despawn when Herod dies or loses aggro, and Trainees are distributed through the hall rather than at one point.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.