TrinityCore / TrinityCore/TrinityCore

Core/Professions: Player must play an emote when discovered new transmutation (recipe or incription?)

Open
#24,947 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Branch-3.3.5a Comp-C++Script
Dominant language
C++
Stars
10.8k
Forks
6.4k
Avg merge
3d 16m
Merged PRs (30d)
6

Description

All emotes are here:

SELECT * FROM broadcast_text WHERE TEXT LIKE '%discovery!  %'

The thing is I don't know why these are not used in WotLK:

SELECT * FROM broadcast_text WHERE TEXT LIKE '%discovery!  %' AND id BETWEEN 12440 AND 29999

I found WotLK videos and screenshots only with 'DISCOVERY! $n has discovered a new transmutation!'
And nothing related to DISCOVERY! $n has discovered a new inscription!
Or to DISCOVERY! $n has discovered a new recipe!

335 Alchemy transmutations:
https://youtu.be/tw_Sy3ldH_E?t=112
https://idtankthat.com/wp-content/uploads/2011/03/5-kings-amber.png
https://i.imgur.com/XGc2ce6.png

TBC Alchemy transmutations / potions / flasks:
https://wow.zamimg.com/uploads/screenshots/normal/21020-.jpg
https://wow.gamepedia.com/File:Alchdiscovery.jpg
https://wow.zamimg.com/uploads/screenshots/normal/21905-.jpg
https://ardentdefense.wordpress.com/2007/10/08/alchemy-new-discovery/
https://potshot.files.wordpress.com/2008/04/disco4.jpg?w=362
https://potshot.files.wordpress.com/2008/04/disco3.jpg?w=383
https://1.bp.blogspot.com/_zDsXVCRDCxE/R0lDGN-8CeI/AAAAAAAAAM4/U1jDuRGh9Aw/s400/discovery4.jpg

Branch: 3.3.5
TC rev. hash/commit: 32aebc14abbb

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by checking the broadcast_text rows returned by the issue's discovery queries on the 3.3.5 branch, then trace the profession discovery handling for transmutations, recipes, and inscriptions. The issue names no source files or tests; done means confirming the intended WotLK behavior and ensuring the appropriate discovery emote is played for each applicable profession result.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, sql
Domain
databases, game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.