TrinityCore / TrinityCore/TrinityCore

Loading saved respawn time messages spam during server startup

Open
#23,712 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Branch-3.3.5a
Dominant language
C++
Stars
10.8k
Forks
6.4k
Avg merge
3d 16m
Merged PRs (30d)
6

Description

Description:

There are too many messages after update TrinityCore in server log when server is starting up connected to respawns.

Current behaviour:

There are errors after update TrinityCore in log when server is starting connected to respawns.
It does not get deleted after some time.
It stucks there every startup.

Expected behaviour:

There should not be these messages in so many count.
"Loading saved respawn time of XXXXXXXX for spawnid (XXXXX) - spawn does not exist, ignoring.

Steps to reproduce the problem:

  1. Update Trinity to the https://github.com/TrinityCore/TrinityCore/commit/af874a211c0f064bd685cddeded3ca7d6d690e8f (from 4 months old core)
  2. See the startup messages spam.
  3. See log: https://pastebin.com/935UYizM

=> The structure of the logs is also wrong it seems - it says spawnid (0,302075) etc.
=> Should we truncate the table to fill it in with the correct data after server resets all instances?

Branch(es):

3.3.5

TC rev. hash/commit:

https://github.com/TrinityCore/TrinityCore/commit/af874a211c0f064bd685cddeded3ca7d6d690e8f

Operating system: Debian Linux 64bit

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the startup log on the 3.3.5 branch using the linked commit and compare the exact respawn-loading message with the provided log. Trace the startup path that loads saved respawn times; done means invalid spawn records no longer produce excessive messages and the spawn ID output is correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
database
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.