TrinityCore / TrinityCore/TrinityCore
Core/Spell: Auras are supposed to only refresh duration, not be removed and applied
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.8k
- Forks
- 6.4k
- Avg merge
- 3d 16m
- Merged PRs (30d)
- 6
Description
Description: When a unit has an aura and the spell that apply this aura hit it, the duration of the aura must be refresh, but in the current revision the aura is removed and a new one is applied
Also Spells like https://woehead.way-of-elendil.fr/?spell=50002 that trigger an other spell every X secs, mustn't be triggered if the caster already has the aura from the triggered spell.
Steps to reproduce the problem:
- .go c id 24707
- .add 34082
- Wear the Diving Helm
- go underwater an notice the breath bar will appear and disappear every 1 secs
Branch(es): 3.3.5
TC rev. hash/commit: rev. e4658a1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the behavior with creature 24707, spell 34082, and the Diving Helm on the 3.3.5 branch. Trace the core spell and aura handling for aura refreshes and the triggered spell described by spell 50002. Done means an existing aura keeps its application and only refreshes duration, while the periodic trigger does not reapply an aura already present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100