TrinityCore / TrinityCore/TrinityCore
[3.3.5] Additem command
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.8k
- Forks
- 6.4k
- Avg merge
- 3d 16m
- Merged PRs (30d)
- 6
Description
Description:
2 things about the .additem command.
-
Use .add xxx -1 on a player who does not have that item and the command will display
"Removed ItemID = xxx, amount = 1 from [Player]"
I mean, this message will be displayed even when the command does nothing.
Is it possible to change this to show an error if nothing is removed? -
The command does not allow to remove items if player is offline.
Would be better if the command would do it?
(This one is just a suggestion)
Branch(es): 3.3.5
TC rev. hash/commit: 00958c9178781ac11a9dcabd034ed2e82120fad6
Operating system: Win 8.1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the TrinityCore command handling for the .additem command on branch 3.3.5 and reproduce both reported cases: removing a missing item from an online player and removing an item from an offline player. Determine whether the command reports a removal only when one occurs, and whether offline removal is supported; verify the resulting command behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend, cli
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100