TrinityCore / TrinityCore/TrinityCore

Core/Spell: Spell ranking downscaling does not work properly

Open
#22,529 5 comments 0 reactions 1 assignee View on GitHub

@ariel- is already working on this.

Since Sep 26, 2018.

Branch-3.3.5a Comp-Core Sub-Spells
Dominant language
C++
Stars
10.8k
Forks
6.4k
Avg merge
3d 16m
Merged PRs (30d)
6

Description

Description:

Level 80 Warrior is able to apply Battle Shout Rank 9 to Level 39, when in fact it should downscale to Rank 3 (just crude example)

Current behaviour:

Apply any buff in theory to lower level and they should receive full rank buff.

Expected behaviour:

Applied buff SHOULD downscale to whatever rank that player is able to receive.

Steps to reproduce the problem:

  1. Create 80 char (Example, warrior), train it fully.
  2. Create level 39 character (any).
  3. Apply Battle shout on lower level target.
  4. Lower level should receive 550 Attack power, which is wrong.

Branch(es):

3.3.5, master is not affected as it does not count based on flat value, rather cata+ rely on percentage value.

TC rev. hash/commit:

TrinityCore rev. 0b0bbe4 2018-09-25

Operating system: Unix Debian 9 x64

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.