TrinityCore / TrinityCore/TrinityCore

Pet/Movement: PetAI interrupts movement spells when not in combat

Open
#22,039 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Branch-master Comp-Core Sub-PetMinion
Dominant language
C++
Stars
10.8k
Forks
6.4k
Avg merge
3d 16m
Merged PRs (30d)
6

Description

Description:

Current behaviour:

When the player is casting a pet spell which would move the pet to a enemy (not in combat with the enemy), the pet will start the movement and immediatley follow his master again.

As Example:
A Unholy Deathknight with his http://www.wowhead.com/spell=207313/sludge-belcher Pet is casting http://www.wowhead.com/spell=212469/hook on a Trainingsdummy, which results in the dummy is immune against the grip and the pet is jumping to the dummy. The Sludge Belcher Pet will start jumping and will fall after jumping and will follow the Deathknight again.

Expected behaviour:

The Pet should finish his uninterruptable movement and after he isn't in combat or isn't in "Stay State" he should follow his master again.

Steps to reproduce the problem:

  1. Create a Unholy DK
  2. Skill Sludge Belcher Talent
  3. Let the Sludge Belcher cast his hook spell on a dummy
  4. See the result

Branch(es): master

TC rev. hash/commit: 170d10b8a92ccbe2349ed1950a3312f477cffceb

Operating system: Windows 10

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Reproduce the issue with the Unholy Death Knight, Sludge Belcher, Hook, and a training dummy, then trace the PetAI movement and follow behavior. Done means the pet completes the uninterruptible movement before following its master when it is neither in combat nor in Stay state.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.