TrinityCore / TrinityCore/TrinityCore
[Master] Fire and Brimstone talent always on
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.8k
- Forks
- 6.4k
- Avg merge
- 3d 16m
- Merged PRs (30d)
- 6
Description
Description:
The effect of [Fire and Brimstone] (incinerate on multiple targets) is active both before choosing any talent in that tier, and after choosing a different one.
Expected behaviour:
Should only apply when [Fire and Brimstone] is chosen
Steps to reproduce the problem:
- Log in on a warlock char
- Make him destro
- Cast incinerate on a group of mobs
Branch(es):
Master
TC rev. hash/commit:
TrinityCore rev. 6f0078a89dab 2018-04-15 13:33:25 +0200 (master branch) (Win64, RelWithDebInfo, Static)
Operating system: Windows 10
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue on the master branch with a destruction warlock by casting Incinerate on multiple targets before selecting a talent and after selecting a different talent. Trace the Fire and Brimstone talent handling and verify that multi-target Incinerate behavior occurs only when that talent is selected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100