TrinityCore / TrinityCore/TrinityCore

[3.3.5a] Right clicking/enabling auto-attack causes pet to attack

Open
#20,538 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Branch-3.3.5a Comp-Core Sub-PetMinion
Dominant language
C++
Stars
10.8k
Forks
6.4k
Avg merge
3d 16m
Merged PRs (30d)
6

Description

Description:

Warlock imps set to Defensive stance should not auto attack on player right click/enable auto attack.

I wanted to find a video to back me up on this, but unfortunately no dice. Unfortunately, I didn't have time to go over all Warlock minions last night, but this could be a generalizable case.

Current behaviour:

Currently, right-clicking on a mob - even one out of melee range - enables pet attack for Imps in Defensive stance.

Expected behaviour:

Imps should not attack until the targeted mob is hit by spellcast or wand autoattack.

Steps to reproduce the problem:

  1. Create any Warlock and learn Summon Imp.
  2. Summon the imp and right click a mob.
  3. The imp will start attacking or casting Firebolt if Firebolt cast is enabled.

Branch(es):

3.3.5a

TC rev. hash/commit:

1af6df4

TDB version: 335.63 w/updates

Operating system: Ubuntu 16.04

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue on the 3.3.5a branch using the listed Warlock and Summon Imp steps, testing Defensive stance and Firebolt enabled or disabled. Trace the pet attack behavior triggered by right-clicking or enabling auto-attack; done means the Imp waits until the target is hit by the player's spellcast or wand autoattack.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.