TrinityCore / TrinityCore/TrinityCore
Scripts/Spells: Cold Blood & Mutilate
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.8k
- Forks
- 6.4k
- Avg merge
- 3d 16m
- Merged PRs (30d)
- 6
Description
Description:
Mutilate doesn't crit for the two attacks it creates after using Cold Blood.
Steps to reproduce the problem:
- Cast Cold Blood.
- Cast Mutilate.
It should crit for the main hand and off hand attacks.
Currently it only crits for main hand attack. and off attack doesn't crit.
Branch(es):
3.3.5a.
TC rev. hash/commit:
https://github.com/TrinityCore/TrinityCore/commit/cb9b9f7247c57ee0eed42b063b827799166ce20a
TDB version:
TDB 335.63.
Operating system:
Win64.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Cold Blood and Mutilate sequence on the 3.3.5a branch, then trace the spell handling for the two attacks it creates. Confirm that both the main-hand and off-hand attacks receive the critical-hit effect, and verify the behavior against the reported reproduction steps.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100