TrinityCore / TrinityCore/TrinityCore

Guild vendor sells all of the guild rewards freely.

Open
#18,518 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Branch-master
Dominant language
C++
Stars
10.8k
Forks
6.4k
Avg merge
3d 16m
Merged PRs (30d)
6

Description

Description:

The vendor npc SAHY PRESSLER(GUID 313942) located in STORMWIND at X: -8887.959961 Y:608.322998 Z: 95.340897 is broken.

Current behaviour: (Tell us what happens.)

The npc sells all of the guild rewards freely to a player that has not completed the required achievments(also sell the items to a player that does not belong to a guild). so if a player have the gold can acquire the items.

Expected behaviour: (Tell us what should happen instead.)

The guild rewards can only be bought by players that belongs to a guild and this player must have completed the achievments for the item, the vendor shall only show the items that you can acquire depending if you have completed the requirements for the listed item.

Steps to reproduce the problem:

1- Travel to stormwind.
2- Talk to the npc SAHY PRESSLER LOCATED AT X: -8887.959961 Y:608.322998 Z: 95.340897

Branch(es): 3.3.5 / master (Tell us which branch(es) this issue affects.)
Master

TC rev. hash/commit:
bc758991140e961ceac46b17b766b0d54b8129fb

TDB version:
7.0.3+updates

Operating system:
Windows 10

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the problem by visiting Sahy Pressler (GUID 313942) in Stormwind and checking the guild reward vendor's available items for guild and non-guild players. Confirm that access and visibility are restricted by guild membership and the required achievements, then repeat the listed interaction to verify the restrictions.

Written by the indexing model from the issue text.

Assessment

Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.