TrinityCore / TrinityCore/TrinityCore

Cleanup bags button freezes inventory

Open
#17,564 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Branch-master Comp-Core
Dominant language
C++
Stars
10.8k
Forks
6.4k
Avg merge
3d 16m
Merged PRs (30d)
6

Description

Description:
When you go into your backpack and click on "Cleanup bags" button (top-right corner of the bag UI) your items freezes (their icons turn gray). In order to unfreeze them you have to relog.

Current behaviour: Clicking on "Cleanup bags" button (top-right corner of the bag UI) your items freezes (their icons turn gray)

Expected behaviour: Items in the bag should be sorted or "cleaned up" like in retail or at the very least the button should not freeze your items and do nothing instead (until cleanup feature is implemented).

Steps to reproduce the problem:

  1. Open your character's backpack
  2. Click on "Cleanup bags" button at top-right corner of bag UI.

Branch(es): 6.x

TC hash/commit: 22d29ce0494c32a73e20646d2320a44a5eb2e633

TDB version: 6.04

Operating system: Windows 10 64bit

P.S. While it is quite a minor issue, my suggestion would be to disable button all-together (user presses it and nothing happens) until its functionality is implemented.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue on the 6.x branch at commit 22d29ce0494c32a73e20646d2320a44a5eb2e633 by opening the backpack and clicking the top-right "Cleanup bags" button. Trace the backpack UI entry point and verify that cleanup either sorts the items or leaves them usable without freezing; if cleanup is not implemented, the button should safely do nothing.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.