TrinityCore / TrinityCore/TrinityCore

Core/Entities: installing vehicle accessories

Open
#15,224 21 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Branch-3.3.5a Branch-master Comp-Core Priority-FutureFeatureRequest Sub-Vehicles
Dominant language
C++
Stars
10.8k
Forks
6.4k
Avg merge
3d 16m
Merged PRs (30d)
6

Description

hash 747ea7c
3.3.5 branch
TDB 335.59

Add accessories with vehicle_template_accessory doesn't work for some vehicles, such as:

VehicleId: 341 - Flame Leviathan Seat (http://www.wowhead.com/npc=33114),

How to reproduce:
1 - Run:

DELETE FROM `vehicle_template_accessory` WHERE `entry` IN (33114);
INSERT INTO `vehicle_template_accessory` (`entry`, `accessory_entry`, `seat_id`, `minion`, `description`, `summontype`, `summontimer`) VALUES
(33114, 33142, 1, 1, 'Flame Leviathan Seat', 6, 30000),
(33114, 33143, 2, 1, 'Flame Leviathan Seat', 6, 30000);

Note that 33114 is an accessory of 33113.

2 - Spawn the seat with .npc add 33114 (note that it will install the accessories correctly)
3 - Spawn the boss .npc add 33113 (note that the seat will be empty-his accessories will despawn)

It seems to happen when a vehicle with its own accessories, is an accessory of another vehicle.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by applying the supplied vehicle_template_accessory SQL and reproducing the nested vehicle spawn sequence with .npc add 33114 and .npc add 33113. Trace the vehicle accessory handling for a vehicle that is itself an accessory, and consider the issue done when the seat's accessories remain installed after the boss is spawned.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, sql
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.