TriangleDataCenter / TriangleDataCenter/Triangle-Simulator
Null array returned in TDIFlyGB with drop_points=0
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 34
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Description
Description
Calling TDIFlyGB to calculate the waveform in time domain with default drop_points=0 will return an array filled with 0.
Reason
The 360th line of TDIFly.py
res[:, -self.drop_points:] = 0.
means
res[:, 0:] = 0.
and thus causes all the items of the res equal to 0.
Is this an expected mechanism to force non-zero drop_points to be passed in?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in TDIFly.py around line 360 and inspect TDIFlyGB with the default drop_points=0. Reproduce the waveform calculation and determine the intended behavior for zero drop points; done means the result no longer becomes an all-zero array, or the expected restriction is clearly documented and enforced.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100