Traverse-Research / Traverse-Research/gpu-allocator

Create a special error variant for "device removed"

Open
#297 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
497
Forks
82
Avg merge
18d 17h
Merged PRs (30d)
1

Description

As we've seen in https://github.com/Traverse-Research/gpu-allocator/pull/262 ERROR_DEVICE_REMOVED can also be raised out of resource creation functions (on Dx12) which gpu-allocator calls. We have some custom logic to run on specifically those errors, but gpu-allocator currently only returns them back in opaque Internal(String) variant leading to ugly string-compares, when we'd rather match on a stable DeviceRemoved variant that is mapped from ERROR_DEVICE_REMOVED.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked pull request #262 and tracing how gpu-allocator handles ERROR_DEVICE_REMOVED from Dx12 resource creation functions. Identify where errors currently become the opaque Internal(String) variant, then verify that this condition is exposed as a stable DeviceRemoved variant that callers can match without string comparisons.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
computer-graphics
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.