Traverse-Research / Traverse-Research/gpu-allocator
`Allocator::new` should be unsafe
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 497
- Forks
- 82
- Avg merge
- 18d 17h
- Merged PRs (30d)
- 1
Description
Allocator::new should not be safe because there is no guarantee the caller has made sure the ash::Device outlives the allocator.
The AllocatorCreateDesc also needs to be populated so that the instance is the one which created the physical device and the device was created from the physical device.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate Allocator::new and AllocatorCreateDesc in the Rust crate, then inspect how the ash::Device, instance, physical device, and device relationships are represented. The work is done when construction requires the appropriate safety contract and AllocatorCreateDesc records the instance and device provenance described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100