Traverse-Research / Traverse-Research/gpu-allocator
AllocatorVisualizer could/should implement Default
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 497
- Forks
- 82
- Avg merge
- 18d 17h
- Merged PRs (30d)
- 1
Description
Hello,
First of all, thank you for the excellent library.
The AllocatorVisualizer struct (both DX12 and Vulkan) are created using the new() function, which notably has no arguments. One might expect it to implement Default for this reason, but it does not.
There's a clippy lint for this: https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
The Rust API guidelines recommend the same: https://rust-lang.github.io/api-guidelines/interoperability.html
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the AllocatorVisualizer definitions for the Vulkan and DX12 backends and their argument-free new() constructors. Implement Default consistently for both, then run Clippy to verify the new_without_default lint is resolved and the existing test suite still passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- computer-graphics
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100