TraceMachina / TraceMachina/nativelink

//local-remote-execution/generated/config:platform excludes darwin toolchains for non-remote execution builds

Open
#508 3 comments 0 reactions 1 assignee View on GitHub

@aaronmondal is already working on this.

Since Dec 19, 2023.

bug no-effect-in-production
Dominant language
Rust
Stars
1.6k
Forks
244
Avg merge
1d 16h
Merged PRs (30d)
54

Description

Description

//local-remote-execution/generated/config:platform seems to pollute or exclude building locally with bazel on MacOS. The defaults provide do not include darwin toolchains. This is problematic for building locally without using remote execution for builds.

bazel query //local-remote-execution/generated/config:platform --output build
# /Users/adam/workspace/native-link/local-remote-execution/generated/config/BUILD:35:9
platform(
  name = "platform",
  exec_properties = {"container-image": "docker://nativelink-toolchain:lslbs7cb2pdf0lgp14vz6kj9r2xbby55", "OSFamily": "Linux"},
  constraint_values = ["@platforms//os:linux", "@platforms//cpu:x86_64", "@bazel_tools//tools/cpp:clang"],
  parents = ["@local_config_platform//:host"],
)
# Rule platform instantiated at (most recent call last):
#   /Users/adam/workspace/native-link/local-remote-execution/generated/config/BUILD:35:9 in <toplevel>

Loading: 0 packages loaded

Reproduce

On MacOS run (https://gist.github.com/adam-singer/46277e3f61aeaf6a6326520f03dfeb5c#file-gistfile0-txt-L247
)

bazel test -s  //nativelink-store/...

cc: @aaronmondal

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.