TraceMachina / TraceMachina/nativelink
Add worker draining when worker errors out
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.6k
- Forks
- 244
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 54
Description
Spawned from a comment here:
https://reviewable.io/reviews/allada/turbo-cache/122#-NZTearw2sEJWAJFoE_f
In the event a worker returns an error response, we should put the worker into a draining() state and then terminate the worker's connection. This would prevent new jobs from being scheduled on that potentially bad node and causing other jobs to fail.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Begin with the linked Reviewable discussion and trace how worker error responses, worker scheduling, and connection termination are handled. Confirm the worker can enter a draining state after an error and that its connection is terminated. Done means no new jobs are scheduled on that worker after the error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend, build-system, distributed-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100