TraceMachina / TraceMachina/nativelink
Join tasks if they are completed
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.6k
- Forks
- 244
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 54
Description
Currently operations are only joined if they are not completed:
Two actions submitted prior to first's completion:
- Client1: Execute Action(action_info)
- Scheduler: Executing(operation_id(1))
- Client2: Execute Action(same_action_info)
- Scheduler: Executing(operation_id(1))
- Scheduler: Completed(operation_id(1))
Action send after the first's completion:
- Client: Execute Action(same_action_info)
- Scheduler: Executing(operation_id(1))
- Scheduler: Completed(operation_id(1))
- Client: Execute Action(same_action_info)
- Scheduler: Executing(operation_id(2))
This should instead be:
- Client: Execute Action(same_action_info)
- Scheduler: Executing(operation_id(1))
- Scheduler: Completed(operation_id(1))
- Client: Execute Action(same_action_info)
- Scheduler: Completed (operation_id(1))
or:
- Client: Execute Action(same_action_info)
- Scheduler: Executing(operation_id(1))
- Scheduler: Completed(operation_id(1))
- Client: Execute Action(same_action_info)
- Scheduler: Cache Check (operation_id(1))
- Scheduler: Completed (operation_id(1))
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the scheduler's task-joining path for repeated Execute Action requests, especially how completed operations are handled. Compare the event sequences in the issue and add a regression test showing that a later identical action reuses operation_id(1) or its cached result. Done means the second request no longer creates operation_id(2) and completion is reported correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system, distributed-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100