TopoToolbox / TopoToolbox/libtopotoolbox
Label closed basins in `identifyflats`
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 2
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Description
TopoToolbox V2 also labels closed basins in addition to flats and sills. If we can implement this, we can replace its identifyflats completely with the libtopotoolbox implementation. It uses imregionalmin along with some post processing, which should not be too challenging to incorporate into the main scan of identifyflats.
Note that DEMs that have been filled will not have any closed basins, so the existing property-based and snapshot tests will not be sufficient to test this implementation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the identifyflats implementation and inspect its main scan plus the existing property-based and snapshot tests. Review how imregionalmin and its post-processing should identify closed basins, then add coverage using an unfilled DEM. Done means closed basins are labeled alongside flats and sills, with tests that exercise them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- data
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100