Making some hard coded things user-changable
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 0
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
Hi William,
A possibly separate issue. I'd like to make some hard coded things user-changable, since I'm revisiting the code. e.g. wavInterpCombii() has
/As well as ScaleInteract, take out large features if excessively flat/
FlatnessFactor = 3.0; /smaller object has to be more than this many times pointier/
FlatnessCoeffFactor = 4.0; /*if the smaller one has a coefficient within this multiple, it can take it out */
How might it be easiest to do this in Topotoolbox? Default within the code, and a parameters text file?
Thank you,
John
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating wavInterpCombii() and the hard-coded FlatnessFactor and FlatnessCoeffFactor values mentioned in the issue. Determine how a user-facing configuration should supply defaults or overrides; the issue does not name a parameters file, tests, or a defined completion condition.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100