Update `editable` icon in table column manager when controlled by other components
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 40.9k
- Forks
- 5.4k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 202
Description
Description:
The "editable" icon is not displayed in the table column manager when the editable property of a table column is controlled by other components. This icon visually indicates whether a column is editable or not.
Current behavior:
When a component other than the table itself manages a column's editable state, the "editable" icon disappears from the table column manager. This lack of visual cue makes it unclear to users whether the column can be edited or not.
Expected behavior:
The "editable" icon should be displayed in the table column manager regardless of how the editable property is controlled. The icon should reflect the current editable state of the column (enabled or disabled).
Steps to reproduce:
Attaching a video grab for reproducing the issue is recommended
https://github.com/ToolJet/ToolJet/assets/81761482/35a15e00-2478-41d1-93ff-bef07cd2de88
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Start by reproducing the issue in the table column manager using a column whose editable state is controlled externally, then trace how the manager determines and renders the editable icon. Done means the icon remains visible and reflects both enabled and disabled states regardless of which component controls the property.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100