App Crashes When Passing Invalid Data to Alert Action in runJS
Open
Nobody has claimed this yet.
appbuilder
bug
roadmap
- Dominant language
- JavaScript
- Stars
- 40.9k
- Forks
- 5.4k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 202
Description
Version Information
v2.7.0
Environment
ToolJet Cloud / Docker / Linux / MacOS ...
What is the expected behaviour?
The app should not crash and should show an alert with invalid data.
What is the current behaviour?
App is crashing on running runjs action for showAlert with an invalid data, instead of text.
How to reproduce the issue?
- Create an app.
- Create a query
actions.showAlert('error',{}) - Run the query.
Please provide any traces or logs that could help here.
Any possible solutions?
Event should be failed with an error on debugger, invalid data.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with actions.showAlert('error',{}) in a runJS action and inspect the alert action and debugger behavior. Done means invalid alert data no longer crashes the app and instead produces the expected alert or a clear debugger error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100