TooAngel / TooAngel/worlddriven
Automatic closing of stale Pull Requests
@tegamax is already working on this.
Since Oct 10, 2020.
- Dominant language
- JavaScript
- Stars
- 18
- Forks
- 15
- Avg merge
- 8d 14h
- Merged PRs (30d)
- 5
Description
The current logic only merges Pull Requests after a certain amount of time.
I think the same logic could be applied for closing Pull Requests. So if the majority of votes (Request changes) are against merging the PR, the PR should be closed at some point in time. Maybe doing the same type of calculation but inverted and also multiplied by some factor (maybe 10). When that point in time is reached the PR gets closed automatically.
I think the factor makes sense, to give the contributor time to improve on their PR.
E.g. Instead of 10 days time to merge, we would have 100 days time to close. If 80% of the votes are against that PR, it will be closed in 20 days.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.