TomSchimansky / TomSchimansky/CustomTkinter
Requesting Permission to Add Pull Request for Adding 'show' Parameter to ctk_input_dialog.py
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 13.6k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
Hello,
I hope this message finds you well. I'm reaching out to request permission to add a pull request to the CustomTkinter repository. I've made some modifications to the ctk_input_dialog.py file on my local machine to add a 'show' parameter to the input dialog box. This modification allows users to utilize the dialog box for handling passwords securely by hiding the characters as they are typed.
Proposed Changes:
Add a 'show' parameter to the ctk_input_dialog.py file with the following specifications:
Default value: None
Type: Optional[str]
Description: Specifies the character to display in place of the actual characters entered by the user. If set to None, the characters will be displayed as entered.
Reason for Change:
The addition of the 'show' parameter enhances the versatility and utility of the input dialog box provided by CustomTkinter. It enables users to conveniently handle password input within their applications while maintaining security and privacy.
Testing:
I've thoroughly tested the modified ctk_input_dialog.py file on my local machine to ensure its functionality and compatibility with existing code. The changes have been validated to work as intended without causing any adverse effects on other functionalities.
Request for Permission:
I kindly request permission to submit a pull request to the CustomTkinter repository to incorporate these modifications. I believe that these changes will benefit the community of CustomTkinter users by providing them with an improved and more comprehensive toolkit for building graphical user interfaces in Python.
Additional Comments:
If there are any specific guidelines or procedures I should follow when submitting the pull request, please let me know. I'm committed to adhering to the project's standards and contributing positively to its development.
Thank you for considering my request. I look forward to your response and the opportunity to contribute to the CustomTkinter project.
Warm regards,
Clement2987
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading ctk_input_dialog.py and its existing input-dialog API. Verify how the proposed show parameter should behave when it is None and when it specifies a masking character, then manually check both normal and password-style input without disrupting existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100