Time-Appliances-Project / Time-Appliances-Project/Time-Card

Should the version numbers in the CoreList be the same as the version registers?

Open
#104 3 comments 0 reactions 1 assignee View on GitHub

@thschaub is already working on this.

Since Nov 21, 2023.

Dominant language
C
Stars
1.5k
Forks
122
Avg merge
12m
Merged PRs (30d)
1

Description

Should the version number in the CoreList match the number in the Version register of that core? There are some that are different.

timecard0: CoreList 0x10000, register 0x10001, TC SMA Selector Inst0 Slave1
timecard0: CoreList  0x10000, register 0x10001, TC SMA Selector Inst0 Slave2
timecard0: CoreList  0x20001, register 0x20002, TC ToD Slave

I looks like TodSlave.vhd has a different version number (0x20003) from the above 2 ToD version numbers:

constant TodSlaveMajorVersion_Con               : std_logic_vector(7 downto 0) := std_logic_vector(to_unsigned(0, 8));
constant TodSlaveMinorVersion_Con               : std_logic_vector(7 downto 0) := std_logic_vector(to_unsigned(2, 8));
constant TodSlaveBuildVersion_Con               : std_logic_vector(15 downto 0) := std_logic_vector(to_unsigned(3, 16));

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.